You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/29 08:07:31 UTC

[GitHub] [kafka] dajac opened a new pull request #10425: MINOR: Removed deprecated `Metric#value`

dajac opened a new pull request #10425:
URL: https://github.com/apache/kafka/pull/10425


   The `Metric#value` method was deprecated in AK 1.0. It makes sense to remove it in AK 3.0.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10425: KAFKA-12573; Remove deprecated `Metric#value`

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10425:
URL: https://github.com/apache/kafka/pull/10425


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10425: MINOR: Removed deprecated `Metric#value`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10425:
URL: https://github.com/apache/kafka/pull/10425#issuecomment-809311564


   @ijuma Any reason not to do this in 3.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10425: MINOR: Removed deprecated `Metric#value`

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10425:
URL: https://github.com/apache/kafka/pull/10425#issuecomment-809318107


   Seems fine to remove. We should have a JIRA and a note in the upgrade notes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10425: KAFKA-12573; Removed deprecated `Metric#value`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10425:
URL: https://github.com/apache/kafka/pull/10425#issuecomment-809458716


   @ijuma Makes sense. Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10425: KAFKA-12573; Remove deprecated `Metric#value`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10425:
URL: https://github.com/apache/kafka/pull/10425#issuecomment-809983371


   One test failed but it is not related to changes in this PR. Merging it to trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org