You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/05/31 18:58:26 UTC

[jira] [Commented] (BOOKKEEPER-614) Generic stats interface, which multiple providers can be plugged into

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671643#comment-13671643 ] 

Hadoop QA commented on BOOKKEEPER-614:
--------------------------------------

Testing JIRA BOOKKEEPER-614


Patch [0001-BOOKKEEPER-614-Generic-stats-interface-which-multipl.patch|https://issues.apache.org/jira/secure/attachment/12585638/0001-BOOKKEEPER-614-Generic-stats-interface-which-multipl.patch] downloaded at Fri May 31 16:31:05 UTC 2013

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
.    Tests run: 843
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/349/
                
> Generic stats interface, which multiple providers can be plugged into
> ---------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-614
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-614
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-614-Generic-stats-interface-which-multipl.patch
>
>
> Currently we collect stats though JMX. Adding a new stat to JMX is cumbersome, and reading the stats out of JMX is painful if you're not on the same machine. As a consequence, we aren't measuring a fraction of the stuff we should be.
> There are a couple of nice stats packages out there, such as twitter-stats[1] and codahale metrics[2], which would make collection of stats much easier.
> This JIRA is to provide a generic interface, which a metrics backend can be plugged into.
> [1] https://github.com/twitter/commons/tree/master/src/java/com/twitter/common/stats
> [2] http://metrics.codahale.com/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira