You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/04/12 18:59:25 UTC
[GitHub] couchdb-fauxton pull request: React 15
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/700
React 15
Fixes and upgrades for React 15
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton react-15
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/700.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #700
----
commit 5b7199b54bfe1450eb17afeadcd706d30d338374
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-04-12T12:22:42Z
get ready for react 15
commit b3bc7f05f56685ad37328b27491c2507cfa52022
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-04-12T13:09:00Z
enable ES 2015
commit 443132e84572c7aa9c5042f53c1269c88aa78dd8
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-04-12T13:09:32Z
update to react 15
commit 3dd8974f42801e247ca48999cf578b34f2141e6f
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-04-12T15:13:54Z
Change dropdown to react-select
react-select is easier to extend and customize and it also
supports rendering the result-list after a click.
it also supports react 15 and is actively maintained.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React 15
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/700#discussion_r59414019
--- Diff: app/addons/documents/index-results/index-results.components.react.jsx ---
@@ -21,14 +21,18 @@ define([
'../..//fauxton/components.react',
'react-bootstrap',
- 'react-autocomplete',
+ 'react-select',
'react-addons-css-transition-group',
'../../../../assets/js/plugins/prettify'
],
-function (app, FauxtonAPI, React, Stores, Actions, Components, Documents, FauxtonComponents, ReactBootstrap, Autocomplete, ReactCSSTransitionGroup) {
+function (app, FauxtonAPI, React, Stores, Actions, Components, Documents, FauxtonComponents,
+ ReactBootstrap, ReactSelect, ReactCSSTransitionGroup) {
+
+ require('react-select/dist/react-select.css');
--- End diff --
ah good call!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React 15
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/700#discussion_r59412765
--- Diff: app/addons/documents/index-results/index-results.components.react.jsx ---
@@ -21,14 +21,18 @@ define([
'../..//fauxton/components.react',
'react-bootstrap',
- 'react-autocomplete',
+ 'react-select',
'react-addons-css-transition-group',
'../../../../assets/js/plugins/prettify'
],
-function (app, FauxtonAPI, React, Stores, Actions, Components, Documents, FauxtonComponents, ReactBootstrap, Autocomplete, ReactCSSTransitionGroup) {
+function (app, FauxtonAPI, React, Stores, Actions, Components, Documents, FauxtonComponents,
+ ReactBootstrap, ReactSelect, ReactCSSTransitionGroup) {
+
+ require('react-select/dist/react-select.css');
--- End diff --
Why not just add this to the other defines?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React 15
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/700#issuecomment-209008736
+1 once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: React 15
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---