[GitHub] pritidesai opened a new issue #306: Implicit Runtime for Java is set to nodejs:default

[gi...@git.apache.org]

pritidesai opened a new issue #306: Implicit Runtime for Java is set to nodejs:default
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/306
 
 
   In the [manifest_parser.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/parsers/manifest_parser.go#L248), default runtime is set to nodejs. 
   
   ```
   				kind := "nodejs:default"
   
   				switch ext {
   				case ".swift":
   					kind = "swift:default"
   				case ".js":
   					kind = "nodejs:default"
   				case ".py":
   					kind = "python"
   				}
   ``` 
   
   When an action with .jar or .java extension is specified, the runtime is set to nodejs:default (snippet of the unit tests I was writing)
   
   ```
   --- FAIL: TestComposeActionsForImplicitRuntimes (0.00s)
           Error Trace:    manifest_parser_test.go:510
           Error:          Not equal: 
                           expected: "java"
                           actual: "nodejs:default"
           Messages:       Expected java but got nodejs:default
   FAIL
   ```
   
   Here, default kind should be an empty string, and specifically check for each file extensions (.swift, .js, .py, and .jar), action file extension outside of these four options should be reported instead of setting kind for it to nodejs:default.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services