You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/09/02 18:22:32 UTC
[jira] Created: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
clean up SSTR.open/get and r/m unnecessary synchronization
----------------------------------------------------------
Key: CASSANDRA-413
URL: https://issues.apache.org/jira/browse/CASSANDRA-413
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Attachments: 413.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750648#action_12750648 ]
Jonathan Ellis commented on CASSANDRA-413:
------------------------------------------
committed w/ clarification
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-413:
-------------------------------------
Attachment: 413.patch
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750587#action_12750587 ]
Jun Rao commented on CASSANDRA-413:
-----------------------------------
I am confused by some of the comments. The comment at the head of SSTableReader says "Do not use open() on existing SSTable files; use get() instead.". However, get() is marked as deprecated. Other than that, the patch looks fine.
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-413.
--------------------------------------
Resolution: Fixed
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750634#action_12750634 ]
Jonathan Ellis commented on CASSANDRA-413:
------------------------------------------
You're right, that's needlessly confusing.
I'd like to move to a world where open() gets called by Table.onStart and after that we just use the existing SSTR references. but, in the interim, get() is better than calling open() again.
I'll try to make that more clear.
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-413) clean up SSTR.open/get and r/m
unnecessary synchronization
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-413:
-------------------------------------
Component/s: Core
Fix Version/s: 0.5
> clean up SSTR.open/get and r/m unnecessary synchronization
> ----------------------------------------------------------
>
> Key: CASSANDRA-413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-413
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 413.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.