You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/26 21:26:51 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8298:
Allow overwriting a SQLLab query that has previously been saved
codecov-io edited a comment on issue #8298: Allow overwriting a SQLLab query that has previously been saved
URL: https://github.com/apache/incubator-superset/pull/8298#issuecomment-535692130
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=h1) Report
> Merging [#8298](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0a8f3eb43ff068a8612338015f605f1951ce57b6?src=pr&el=desc) will **decrease** coverage by `5.77%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8298 +/- ##
==========================================
- Coverage 73.53% 67.76% -5.78%
==========================================
Files 115 451 +336
Lines 12396 22730 +10334
Branches 0 2377 +2377
==========================================
+ Hits 9116 15402 +6286
- Misses 3280 7190 +3910
- Partials 0 138 +138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvdXRpbHMvcmVkdXhTdGF0ZVRvTG9jYWxTdG9yYWdlSGVscGVyLmpz) | `100% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.06% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `43.68% <0%> (ø)` | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `86.11% <100%> (ø)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `52.81% <100%> (ø)` | |
| [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `60.76% <46.66%> (ø)` | |
| [...uperset/assets/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TYXZlUXVlcnkuanN4) | `77.27% <93.75%> (ø)` | |
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | `50% <0%> (ø)` | |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | `0% <0%> (ø)` | |
| ... and [333 more](https://codecov.io/gh/apache/incubator-superset/pull/8298/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=footer). Last update [0a8f3eb...ee32e70](https://codecov.io/gh/apache/incubator-superset/pull/8298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org