You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Shazron Abdullah (Created) (JIRA)" <ji...@apache.org> on 2012/04/13 16:06:22 UTC
[jira] [Created] (CB-501) orientationchange event is not being
fired in 1.6.0
orientationchange event is not being fired in 1.6.0
---------------------------------------------------
Key: CB-501
URL: https://issues.apache.org/jira/browse/CB-501
Project: Apache Callback
Issue Type: Bug
Components: iOS
Affects Versions: 1.6.0
Reporter: Shazron Abdullah
Assignee: Shazron Abdullah
Priority: Blocker
Offending line:
https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-501) orientationchange event is
not being fired in 1.6.0
Posted by "Tan Heng (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253705#comment-13253705 ]
Tan Heng edited comment on CB-501 at 4/13/12 8:17 PM:
------------------------------------------------------
Test again and this time event got fired, and just one time every rotation in ios4.3 or 5.0/5.1
Perfect!
was (Author: evan tan):
Test again and this time got fired, and just one time every rotation. Perfect!
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Tan Heng (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253681#comment-13253681 ]
Tan Heng commented on CB-501:
-----------------------------
My steps:
1. Uninstall the original Cordova and delete whole project.
2. git clone from https://git-wip-us.apache.org/repos/asf/incubator-cordova-ios.git(just after CB-501 fixed)
3. make a new Cordova-1.6.0.dmg and install it.
4. Create a new Cordova project, and add line
"document.addEventListener('orientationchange', function(){console.log('orientationchange fired!')})" in onDeviceReady() of index.html
5. Select all of supported device orientations in target settings.
6. Use iphone 4.3 simulator and still cannot get orientationchange event fired :(
I use Xcode 4.3.2 iOS 5.1 sdk, on lion.
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah resolved CB-501.
---------------------------------
Resolution: Fixed
Fix commit: http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=0fefc52ae00bfa4f8b280186a42cc0c649e425d1
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Tan Heng (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253638#comment-13253638 ]
Tan Heng commented on CB-501:
-----------------------------
Corrected that line to lower-case and orientationchange event still not being fired in ios4.3.
Still missing something?
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253669#comment-13253669 ]
Shazron Abdullah commented on CB-501:
-------------------------------------
Test code used:
{code}
function onBodyLoad()
{
document.addEventListener("deviceready", onDeviceReady, false);
}
function onDeviceReady()
{
window.addEventListener("orientationchange", onOrientationChange, false);
}
function onOrientationChange()
{
alert(window.orientation);
}
{code}
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-501) orientationchange event is
not being fired in 1.6.0
Posted by "Tan Heng (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253638#comment-13253638 ]
Tan Heng edited comment on CB-501 at 4/13/12 6:49 PM:
------------------------------------------------------
I have corrected that line to lower-case, recompile, and orientationchange event still not being fired in ios4.3.
Still missing something?
was (Author: evan tan):
Corrected that line to lower-case and orientationchange event still not being fired in ios4.3.
Still missing something?
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Tan Heng (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253686#comment-13253686 ]
Tan Heng commented on CB-501:
-----------------------------
Good to heard that.
Thanks for your guys work.
Confused me for several days.
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah resolved CB-501.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.6.1
http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=9d63d9b9a205d28c63d9ed2c9abe142328a514af
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah reopened CB-501:
---------------------------------
Problem: cordova.fireEvent does not exist. Use cordova.fireWindowEvent.
It works in iOS 5.0 because UIWebView probably supports this natively now.
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Tan Heng (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253705#comment-13253705 ]
Tan Heng commented on CB-501:
-----------------------------
Test again and this time got fired, and just one time every rotation. Perfect!
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253673#comment-13253673 ]
Shazron Abdullah commented on CB-501:
-------------------------------------
Confirmed - in iOS 5.x orientationchange is built in to UIWebView, so the code should not fire an event for iOS 5.x devices. Will add this to the fix. This is what was reported in CB-302 that I couldn't repro earlier.
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-501) orientationchange event is not being
fired in 1.6.0
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253648#comment-13253648 ]
Shazron Abdullah commented on CB-501:
-------------------------------------
What version of Cordova was your project originally created in? Sounds like CB-221
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-501) orientationchange event is
not being fired in 1.6.0
Posted by "Tan Heng (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253638#comment-13253638 ]
Tan Heng edited comment on CB-501 at 4/13/12 6:50 PM:
------------------------------------------------------
I have corrected that line to lower-case, recompile, and orientationchange event still not being fired in ios4.3.
Missing some steps?
was (Author: evan tan):
I have corrected that line to lower-case, recompile, and orientationchange event still not being fired in ios4.3.
Still missing something?
> orientationchange event is not being fired in 1.6.0
> ---------------------------------------------------
>
> Key: CB-501
> URL: https://issues.apache.org/jira/browse/CB-501
> Project: Apache Callback
> Issue Type: Bug
> Components: iOS
> Affects Versions: 1.6.0
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Priority: Blocker
> Fix For: 1.6.1
>
>
> Offending line:
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVViewController.m#L307
> Lower-case Cordova to cordova.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira