You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/25 08:57:35 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
lburgazzoli opened a new pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262
Fixes #1244
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262#issuecomment-633512841
Requires https://issues.apache.org/jira/browse/CAMEL-15109, closing for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli closed pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli closed pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262#issuecomment-633489327
> One nitpick inline. Besides, this should be documented, perhaps on the https://camel.apache.org/camel-quarkus/latest/extensions/rest.html page?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262#discussion_r429847213
##########
File path: integration-tests/rest/src/main/resources/application.properties
##########
@@ -0,0 +1,21 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus
+#
+quarkus.log.file.enable = false
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1262: Make camel-quarkus-rest depend on camel-quarkus-platform-http
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1262:
URL: https://github.com/apache/camel-quarkus/pull/1262#discussion_r429838668
##########
File path: integration-tests/rest/src/main/resources/application.properties
##########
@@ -0,0 +1,21 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus
+#
+quarkus.log.file.enable = false
Review comment:
`false` is the default BTW https://quarkus.io/guides/all-config#quarkus-core_quarkus.log.file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org