You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/20 23:51:10 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8940: Remove side-effect of session in FAB

mik-laj commented on a change in pull request #8940:
URL: https://github.com/apache/airflow/pull/8940#discussion_r428370876



##########
File path: airflow/www/app.py
##########
@@ -70,8 +70,9 @@ def create_app(config=None, session=None, testing=False, app_name="Airflow"):
     app.json_encoder = AirflowJsonEncoder
 
     csrf.init_app(app)
-
-    db = SQLA(app)
+    db = SQLA()

Review comment:
       This creates a new session, but we want to use your global session instead of creating another session.
   https://github.com/pallets/flask-sqlalchemy/blob/706982bb8a096220d29e5cef156950237753d89f/flask_sqlalchemy/__init__.py#L714




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org