You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by gliptak <gi...@git.apache.org> on 2015/11/30 18:59:58 UTC
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
GitHub user gliptak opened a pull request:
https://github.com/apache/phoenix/pull/136
Upgrade ANTLR version to correct generation error with Java 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gliptak/phoenix PHOENIX-2465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 6af9e67fd224060035fa1049c3e01ef6cdbf7845
Author: Gábor Lipták <gl...@gmail.com>
Date: 2015-11-30T17:59:06Z
Upgrade ANTLR version to correct generation error with Java 8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
Posted by gliptak <gi...@git.apache.org>.
Github user gliptak closed the pull request at:
https://github.com/apache/phoenix/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/136#issuecomment-160713601
Thanks, @gliptak. Patch looks fine, but please amend your commit message by prefixing with PHOENIX-2465 so that it gets tied to the JIRA, like this: "PHOENIX-2465 Upgrade ANTLR version to correct generation error with Java 8"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
Posted by gliptak <gi...@git.apache.org>.
Github user gliptak commented on the pull request:
https://github.com/apache/phoenix/pull/136#issuecomment-160742249
@JamesRTaylor I updated the commit message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
Posted by gliptak <gi...@git.apache.org>.
Github user gliptak commented on the pull request:
https://github.com/apache/phoenix/pull/136#issuecomment-192650502
@JamesRTaylor Please review. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Upgrade ANTLR version to correct generation ...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/136#issuecomment-192768633
Weird - this was committed here: https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=21e7c7dd20f19e3f2d30387d472940983bf50d02, but I can't seem to find it here: https://github.com/apache/phoenix/. I'll commit it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---