You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by "Brock Noland (JIRA)" <ji...@apache.org> on 2013/03/12 02:45:12 UTC

[jira] [Commented] (FLUME-1321) BasicTransactionSemantics should never throw from close()

    [ https://issues.apache.org/jira/browse/FLUME-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599581#comment-13599581 ] 

Brock Noland commented on FLUME-1321:
-------------------------------------

Hi guys,

I agree 100% on this. Just a note, there was a long conversation about this here: https://reviews.apache.org/r/4655/ and this is a dup of FLUME-1089.

Brock
                
> BasicTransactionSemantics should never throw from close()
> ---------------------------------------------------------
>
>                 Key: FLUME-1321
>                 URL: https://issues.apache.org/jira/browse/FLUME-1321
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.1.0
>            Reporter: Mike Percy
>            Assignee: Roshan Naik
>             Fix For: v1.4.0
>
>         Attachments: 1321.patch.1
>
>
> Currently, BasicTransactionSemantics can throw from close(). This means that exceptions will be clobbered in cases where unexpected exceptions are thrown, since close() is idiomatically called in a finally block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira