You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2011/10/14 09:32:11 UTC

[jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode

    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127333#comment-13127333 ] 

Hudson commented on OGNL-21:
----------------------------

Integrated in ognl #133 (See [https://builds.apache.org/job/ognl/133/])
    OGNL-21: removed deprecated method

grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183226
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java

                
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira