You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by davidamorimfaria <gi...@git.apache.org> on 2015/10/29 23:53:37 UTC
[GitHub] cloudstack pull request: adjust packaging for centos7
GitHub user davidamorimfaria opened a pull request:
https://github.com/apache/cloudstack/pull/1008
adjust packaging for centos7
Here are a few adjustments for the packaging in centos7. With these changes I was able to start the service. Please review. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidamorimfaria/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1008
----
commit 7bde6405cfbabf6312fff31755de9b29ad8c6b70
Author: David Amorim Faria <d....@tech.leaseweb.com>
Date: 2015-10-29T15:24:06Z
adjust systemd script for centos7 to match tomcat7 init
commit 19f1df89f6e1ae4d8752cc95555cf21b6003192b
Author: David Amorim Faria <d....@tech.leaseweb.com>
Date: 2015-10-29T15:25:27Z
adjust centos7 sysconfig to only have one JAVA_OPTS due to behaviour change in tomcat7
commit 276576e25d92a896cc1735710c9ac1f91a7cf904
Author: David Amorim Faria <d....@tech.leaseweb.com>
Date: 2015-10-29T15:26:01Z
remove some config files from WEB-INF
commit d8d7dd14f1c1c00b9cb740a76be1570d92c44159
Author: David Amorim Faria <da...@gmail.com>
Date: 2015-10-29T22:48:42Z
service does not fork, thus service type must be simple instead of forking
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-160590038
@DaanHoogland I see, leaving it then. CentOS7 users should use 4.6/4.7 then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: adjust packaging for centos7
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152457639
@davidamorimfaria I saw you didn't go for the tomcat instance creation, right?
changes look good and as we discussed off-line.
Can you add a jira ticket name to the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152568600
based on the review of the changes and looking at the deployment of the management servers i think this LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by davidamorimfaria <gi...@git.apache.org>.
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152536728
I haven't installed a cloud with the packages made with this change, but so far the management servers start and talk to each other:
Oct 30 13:54:04 mgmt01 server: WARN [c.c.c.ClusterManagerImpl] (Cluster-Notification-1:ctx-cb4bc2b4) Notifying management server join event took 0 ms
These were the steps I did, using a mariadb 10 as db backend:
- yum localinstall cloudstack-common-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm cloudstack-management-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm cloudstack-usage-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm cloudstack-cli-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
- [in mgmt01] cloudstack-setup-databases cloud:<fancy_password>@localhost
- [in mgmt02] cloudstack-setup-databases cloud:<fancy_password>@<remote_db_ip>
- cloudstack-setup-management
- systemctl enable cloudstack-management
- systemctl start cloudstack-management
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152578560
@davidamorimfaria Final request, please squash your commits. We need them to be atomic. Please ping me when done, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-160588176
@davidamorimfaria @remibergsma should we port this to 4.5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: adjust packaging for centos7
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152471048
Thanks for the fix and the PR, @davidamorimfaria
I will try to test/review this one today.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: adjust packaging for centos7
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152457228
@davidamorimfaria due to a known bug in jenkins/maven integration the build in jenkins failed. Could you repush with git push --force to your branch? I'm reviewing in the meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152573997
This PR fixes CentOS 7 packaging and obsoletes #888 and CLOUDSTACK-8812. I will merge this and close the other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: adjust packaging for centos7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152479205
Seems to start fine now, thanks @davidamorimfaria
Haven't setup a cloud with this or tested it further. Just built RPM packages and started management server.
```
[root@cs2 ~]# systemctl start cloudstack-management
[root@cs2 ~]# systemctl status cloudstack-management
cloudstack-management.service - CloudStack Management Server
Loaded: loaded (/usr/lib/systemd/system/cloudstack-management.service; disabled)
Active: active (running) since Fri 2015-10-30 09:56:41 GMT; 7s ago
Main PID: 11075 (java)
CGroup: /system.slice/cloudstack-management.service
└─11075 java -Djava.awt.headless=true -Dcom.sun.management.jmxremote=false -Xmx2g -XX:+HeapDumpOnOutOfMemo...
Oct 30 09:56:43 cs2 server[11075]: Oct 30, 2015 9:56:43 AM org.apache.catalina.core.StandardEngine startInternal
Oct 30 09:56:43 cs2 server[11075]: INFO: Starting Servlet Engine: Apache Tomcat/7.0.54
Oct 30 09:56:43 cs2 server[11075]: Oct 30, 2015 9:56:43 AM org.apache.catalina.startup.HostConfig deployDirectory
Oct 30 09:56:43 cs2 server[11075]: INFO: Deploying web application directory /usr/share/cloudstack-management/w...client
Oct 30 09:56:43 cs2 server[11075]: Oct 30, 2015 9:56:43 AM org.apache.catalina.loader.WebappClassLoader validateJarFile
Oct 30 09:56:43 cs2 server[11075]: INFO: validateJarFile(/usr/share/cloudstack-management/webapps/client/WEB-IN....class
Oct 30 09:56:43 cs2 server[11075]: Oct 30, 2015 9:56:43 AM org.apache.catalina.loader.WebappClassLoader validateJarFile
Oct 30 09:56:43 cs2 server[11075]: INFO: validateJarFile(/usr/share/cloudstack-management/webapps/client/WEB-IN....class
Oct 30 09:56:43 cs2 server[11075]: Oct 30, 2015 9:56:43 AM org.apache.catalina.loader.WebappClassLoader validateJarFile
Oct 30 09:56:43 cs2 server[11075]: INFO: validateJarFile(/usr/share/cloudstack-management/webapps/client/WEB-IN....class
Hint: Some lines were ellipsized, use -l to show in full.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by davidamorimfaria <gi...@git.apache.org>.
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-160594088
@bhaisaab I see no harm in trying to package 4.5 with this spec. It should just work (read, services start) if all the files expected by the spec file are also included in 4.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-160589376
@bhaisaab I think it is fine to do so, but centos7 support was still experimental. Not sure if we spring hopes there that are unjust.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-160599550
@davidamorimfaria thanks, I personally won't be able to fix/test this soonish so dropping this unless of course you or someone wants this in 4.5 and sends a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...
Posted by davidamorimfaria <gi...@git.apache.org>.
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1008#issuecomment-152712182
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---