You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/06/09 13:35:48 UTC

[GitHub] rabbah commented on a change in pull request #2282: Distributed tracing support #2192

rabbah commented on a change in pull request #2282: Distributed tracing support #2192
URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r121127217
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
 ##########
 @@ -53,7 +54,8 @@ case class ActivationMessage(
     activationId: ActivationId,
     activationNamespace: EntityPath,
     content: Option[JsObject],
-    cause: Option[ActivationId] = None)
+    cause: Option[ActivationId] = None,
+    traceMetadata: Option[SpanMetadata] = None)
 
 Review comment:
   > is this something which can be done independently on similar lines as you and @ddragosd had discussed in previous comments?
   
   no need to wait (as the log drain integration hasn't gotten to the point of building a load time solution yet); OSGI or URLClassLoader with the latter being more lightweight to start.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services