[GitHub] [kylin] TempleZhou commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps

[GitBox <gi...@apache.org>]

TempleZhou commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
URL: https://github.com/apache/kylin/pull/538#issuecomment-476036530
 
 
   > Hi Temple, I think the more clear way is in :
   > 
   > org.apache.kylin.job.JoinedFlatTable#generateCreateTableStatement(org.apache.kylin.metadata.model.IJoinedFlatTableDesc, java.lang.String)
   > 
   > Change ` String storageFormat = flatDesc.getDataModel().getConfig().getFlatTableStorageFormat();`
   > 
   > to
   > ` String storageFormat = flatDesc.getSegment().getConfig().getFlatTableStorageFormat();`
   > 
   > Which is to say, here using segment level config (which is also the cube level) is better than the model level config. Just let me know your idea.
   
   Oh ~ you are right, changing the dataModel is a foolish way as there are different cube use same model.
   I have tested the change you advised, no problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services