You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 00:38:02 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1592: Fix map nullable flag in `ParquetTypeConverter`

viirya commented on code in PR #1592:
URL: https://github.com/apache/arrow-rs/pull/1592#discussion_r853634328


##########
parquet/src/arrow/schema.rs:
##########
@@ -1018,7 +1018,7 @@ impl ParquetTypeConverter<'_> {
                         Box::new(Field::new(
                             key_item.name(),
                             DataType::Struct(vec![key, value]),
-                            false,
+                            self.schema.is_optional(),

Review Comment:
   Due to previous inconsistency I described in the ticket, I changed this to follow `visit_map`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org