[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1447: fix: Fault-tolerant storage engine errors for read operations

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1447:
URL: https://github.com/apache/incubator-pegasus/pull/1447#discussion_r1174786959


##########
src/runtime/serverlet.h:
##########
@@ -90,6 +90,8 @@ class rpc_replier
         return _response != nullptr ? _response->to_address : rpc_address::s_invalid_address;
     }
 
+    int error_code() const { return _response != nullptr ? _response->error() : 0; }

Review Comment:
   Only simple_kv use this register function, simple_kv is just a simple demo of rdsn framework, so I'll update the code to limit the usage of function
   ```
   template <typename TReq, typename TResp>
   static bool register_async_rpc_handler(...)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org