You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "polyzos (via GitHub)" <gi...@apache.org> on 2026/10/22 05:42:07 UTC
Re: [PR] Change the implementation of Admin#getServerNodes() to support carrying ServerTag [fluss]
polyzos commented on PR #1410:
URL: https://github.com/apache/fluss/pull/1410#issuecomment-6333669251
Thanks @LiebingYu for the work 👍 can you please rebase the branch.. and a few more thoughts:
1. **Older servers.** `getServerNodes()` works against any server because it uses the metadata request. With the new RPC, a newer client talking to a 1.0 cluster would fail, for example during a rolling upgrade. Falling back to the current path when the server doesn't support the new RPC, with tags left empty, would keep it working.
2. **ZooKeeper read per call.** The request goes to a random TabletServer, which doesn't cache tags, so each call reads ZooKeeper on a request thread. The coordinator's metadata cache on `main` now keeps tags in memory, so serving the call from there would avoid that. Could you reply on @affo's thread with the approach you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org