[jira] [Commented] (HBASE-14343) Fix debug message in SimpleRegionNormalizer for small regions

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724455#comment-14724455 ] 

Hadoop QA commented on HBASE-14343:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12753411/HBASE-14343-extended.patch
  against master branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
  ATTACHMENT ID: 12753411

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs (version 2.0.3) to fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn post-site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15374//testReport/
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15374//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15374//console

This message is automatically generated.

> Fix debug message in SimpleRegionNormalizer for small regions
> -------------------------------------------------------------
>
>                 Key: HBASE-14343
>                 URL: https://issues.apache.org/jira/browse/HBASE-14343
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 1.1.1
>            Reporter: Lars George
>            Assignee: Lars Francke
>            Priority: Trivial
>              Labels: beginner
>         Attachments: HBASE-14343-extended.patch, HBASE-14343.patch
>
>
> The {{SimpleRegionNormalizer}} has this:
> {code}
>      if ((smallestRegion.getSecond() + smallestNeighborOfSmallestRegion.getSecond()
>           < avgRegionSize)) {
>         LOG.debug("Table " + table + ", smallest region size: " + smallestRegion.getSecond()
>           + " and its smallest neighbor size: " + smallestNeighborOfSmallestRegion.getSecond()
>           + ", less than half the avg size, merging them");
> {code}
> It does *not* check for "less than half the avg size" but only "less than the avg size", that is, drop the "half". Fix message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)