You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/04 01:08:06 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #4315: test: add chaos test on network delay between apisix and etcd

spacewander commented on a change in pull request #4315:
URL: https://github.com/apache/apisix/pull/4315#discussion_r682212888



##########
File path: t/chaos/killetcd/killetcd.go
##########
@@ -90,15 +84,30 @@ var _ = ginkgo.Describe("Test Get Success When Etcd Got Killed", func() {
 	defer ginkgo.It("restore test environment", func() {
 		stopChan <- true
 		cliSet.CtrlCli.Delete(context.Background(), getEtcdKillChaos())
+
+		resp := utils.SetRouteIgnoreError(e)

Review comment:
       Need to avoid repeating the waiting code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org