[GitHub] [pulsar] eolivelli commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r947672236


##########
buildtools/src/main/resources/pulsar/checkstyle.xml:
##########
@@ -39,6 +39,9 @@ page at http://checkstyle.sourceforge.net/config.html -->
         <property name="max" value="120"/>
         <property name="severity" value="error"/>
 
+        <!-- Checks only for Java files. -->
+        <property name="fileExtensions" value="java"/>

Review Comment:
   this should be a separate PR



##########
distribution/server/src/assemble/bin.xml:
##########
@@ -23,6 +23,7 @@
           xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
   <id>bin</id>
   <formats>
+    <format>dir</format>

Review Comment:
   this looks like only convenient for debugging purposes. please remove.
   the Pulsar repo is already huge when you build it (more than 5GB)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org