[GitHub] jiazhai opened a new pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

[GitBox <gi...@apache.org>]

jiazhai opened a new pull request #781: Issue 780:   change BK_statsProviderClass in to NullStatsProvider in Docker file
URL: https://github.com/apache/bookkeeper/pull/781
 
 
   Descriptions of the changes in this PR:
   In issue #732, we changed Makefile for Docker:
   BK_statsProviderClass=org.apache.bookkeeper.stats.NullStatsProvider
   to avoid error:
   java.lang.ClassNotFoundException: org.apache.bookkeeper.stats.PrometheusMetricsProvider
   
   It is more safe to change the default env in Dockerfile instead of Makefile. So that user use the default 4.5.1 Docker will not meet error.
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   > 
   > - [x] Make sure the PR title is formatted like:
   >     `<Issue # or BOOKKEEPER-#>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   >     `e.g. BOOKKEEPER-1234: Description ...`
   > - [x] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
   > - [x] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services