You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2023/02/14 22:50:31 UTC

[GitHub] [hudi] jonvex opened a new pull request, #7949: [HUDI-5795] Ensure we only have a single push gw client and hence a single connection pool

jonvex opened a new pull request, #7949:
URL: https://github.com/apache/hudi/pull/7949

   ### Change Logs
   
   Currently we maintain a single Metrics instance per table (and a separate one for metadata table). That means we create a separate instance for PushGateway, the client for push gateway. This implies that we have a connection pool per hudi table, that is leading to a lot of open/waiting/blocked TCP connections on the push gw, possibly causing it to crash. 
   
   In this PR, we ensure that we use a single PushGateway instance per hostname and port, ensuring we only maintain a single connection pool per PushGw Server Instance
   
   ### Impact
   
   Reduces chance of exception
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7949: [HUDI-5795] Ensure we only have a single push gw client and hence a single connection pool

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7949:
URL: https://github.com/apache/hudi/pull/7949#issuecomment-1430501383

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d84a59f5668f181672f3324d032ce56043acbbde UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7949: [HUDI-5795] Ensure we only have a single push gw client and hence a single connection pool

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7949:
URL: https://github.com/apache/hudi/pull/7949#issuecomment-1430753772

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15180",
       "triggerID" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d84a59f5668f181672f3324d032ce56043acbbde Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15180) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #7949: [HUDI-5795] Ensure we only have a single push gw client and hence a single connection pool

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #7949:
URL: https://github.com/apache/hudi/pull/7949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7949: [HUDI-5795] Ensure we only have a single push gw client and hence a single connection pool

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7949:
URL: https://github.com/apache/hudi/pull/7949#issuecomment-1430529218

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15180",
       "triggerID" : "d84a59f5668f181672f3324d032ce56043acbbde",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d84a59f5668f181672f3324d032ce56043acbbde Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15180) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org