You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/24 19:18:05 UTC

[GitHub] [beam] milancermak commented on a change in pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

milancermak commented on a change in pull request #12918:
URL: https://github.com/apache/beam/pull/12918#discussion_r494554848



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
     return destination
 
 
+def no_retry_on_invalid_input(exn):
+  if isinstance(exn, ValueError):
+    return False
+  return retry.retry_on_server_errors_and_timeout_filter(exn)

Review comment:
       Yeah, I was thinking the same. Looking at the source of retry.py, it would fit right in (maybe with a better name?). I'm fine with moving it there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org