[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #16198: [fix] Update `test_update_ops_mutation` tolerance

[GitBox <gi...@apache.org>]

sxjscience commented on a change in pull request #16198: [fix] Update `test_update_ops_mutation` tolerance
URL: https://github.com/apache/incubator-mxnet/pull/16198#discussion_r325817815
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -1887,14 +1888,16 @@ def check_save_load(save_is_np_shape, load_is_np_shape, shapes, save_throw_excep
     check_save_load(True, True, [(2, 0, 1), (0,), (), (), (0, 4), (), (3, 0, 0, 0), (2, 1), (0, 5, 0)], False, False)
 
 
-@with_seed()
-def test_update_ops_mutation():
-    def assert_mutate(x, y, op):
+def _test_update_ops_mutation_impl():
+    assert_allclose = functools.partial(
+                np.testing.assert_allclose, rtol=1e-10)
 
 Review comment:
   I think we need to lower the rtol because sometimes it fails the assert_raise check

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services