You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "abandy (via GitHub)" <gi...@apache.org> on 2023/07/07 13:46:48 UTC
[GitHub] [arrow] abandy opened a new pull request, #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
abandy opened a new pull request, #36547:
URL: https://github.com/apache/arrow/pull/36547
The initial implementation for swift arrow flight.
This change depends on PR GH-36544.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36547:
URL: https://github.com/apache/arrow/pull/36547#issuecomment-1655871534
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b9a647023de40a670ec8d9c32ff6e205debfaa8d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15432705309) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1260470651
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
Review Comment:
Could you add a license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1268301441
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ }catch {
+ print("Unknown server error: \(error)")
+ }
+ }
+}
+
+public class FlightClientImpl {
+ var client: FlightClient?
+ var group: MultiThreadedEventLoopGroup?
+ var channel: GRPCChannel?
+
+ init() async throws {
+ // Load the features.
+ let group = PlatformSupport.makeEventLoopGroup(loopCount: 1)
+ let channel = try GRPCChannelPool.with(
+ target: .host("localhost", port: 8088),
+ transportSecurity: .plaintext,
+ eventLoopGroup: group
+ )
+
+ client = FlightClient(channel: channel)
+ }
+
+ deinit {
+ try? group?.syncShutdownGracefully()
+ try? channel?.close().wait()
+ }
+
+ func listActionTest() async throws {
+ var actionTypes = [FlightActionType]()
+ try await client?.listActions( { action in
+ actionTypes.append(action)
+ })
+
+ XCTAssertEqual(actionTypes.count, 2)
+ XCTAssertEqual(actionTypes[0].type, "type1")
+ XCTAssertEqual(actionTypes[0].description, "desc1")
+ XCTAssertEqual(actionTypes[1].type, "type2")
+ XCTAssertEqual(actionTypes[1].description, "desc2")
+ }
+
+ func listFlightsTest() async throws {
+ let flightCriteria = FlightCriteria("flight criteria expression".data(using: .utf8)!)
+ var num_calls = 0
+ try await client?.listFlights(flightCriteria, closure: { data in
+ num_calls += 1
+ let schema = try streamToArrowSchema(data.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ })
+
+ XCTAssertEqual(num_calls, 1)
+ }
+
+ func doActionTest() async throws {
+ let action = FlightAction("test_action", body: "test_action body".data(using: .utf8)!)
+ var actionResults = [FlightResult]()
+ try await client?.doAction(action, closure: { result in
+ actionResults.append(result)
+ })
+
+ XCTAssertEqual(actionResults.count, 1)
+ XCTAssertEqual(String(bytes:actionResults[0].body, encoding: .utf8), "test_action result")
+ }
+
+ func getSchemaTest() async throws {
+ let descriptor = FlightDescriptor(cmd: "schema info".data(using: .utf8)!)
+ let schemaResult = try await client?.getSchema(descriptor)
+ let schema = try streamToArrowSchema(schemaResult!.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ }
+
+ func doGetTest() async throws {
+ let ticket = FlightTicket("flight_ticket test".data(using: .utf8)!)
+ var num_call = 0
+ try await client?.doGet(ticket, readerResultClosure: { rb in
+ num_call += 1
+ XCTAssertEqual(rb.schema!.fields.count, 3)
+ XCTAssertEqual(rb.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doPutTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doPut([rb], closure: { result in
+ num_call += 1
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doExchangeTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doExchange([rb], closure: { result in
+ num_call += 1
+ XCTAssertEqual(result.schema?.fields.count, 3)
+ XCTAssertEqual(result.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+}
+
+var serverup = false
Review Comment:
Will move variable into a Actor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36547:
URL: https://github.com/apache/arrow/pull/36547#issuecomment-1627506810
I've merged #36544. Could you rebase on main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1268291447
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
Review Comment:
Will update.
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ }catch {
+ print("Unknown server error: \(error)")
+ }
+ }
+}
+
+public class FlightClientImpl {
Review Comment:
Will change to FlightClientTester.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36547:
URL: https://github.com/apache/arrow/pull/36547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36547:
URL: https://github.com/apache/arrow/pull/36547#issuecomment-1625442764
:warning: GitHub issue #36546 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on PR #36547:
URL: https://github.com/apache/arrow/pull/36547#issuecomment-1630988215
> I've merged #36544. Could you rebase on main?
Awesome, thank you! Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1268290947
##########
swift/ArrowFlight/Sources/ArrowFlight/FlightClient.swift:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+public class FlightClient {
+ let client: Arrow_Flight_Protocol_FlightServiceAsyncClient
+ public init(channel: GRPCChannel) {
+ client = Arrow_Flight_Protocol_FlightServiceAsyncClient(channel: channel)
+ }
+
+ public func listActions(_ closure: (FlightActionType) -> Void) async throws {
+ let listActions = client.makeListActionsCall(Arrow_Flight_Protocol_Empty())
+ for try await data in listActions.responseStream {
+ closure(FlightActionType(data))
+ }
+ }
+
+ public func listFlights(_ criteria :FlightCriteria, closure: (FlightInfo) throws -> Void ) async throws {
Review Comment:
Will change, agreed, I will start looking around for a formatter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1268791512
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,302 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ } catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ } catch {
+ print("Unknown server error: \(error)")
+ }
+ }
+}
+
+public class FlightClientTester {
+ var client: FlightClient?
+ var group: MultiThreadedEventLoopGroup?
+ var channel: GRPCChannel?
+
+ init() async throws {
+ // Load the features.
+ let group = PlatformSupport.makeEventLoopGroup(loopCount: 1)
+ let channel = try GRPCChannelPool.with(
+ target: .host("localhost", port: 8088),
+ transportSecurity: .plaintext,
+ eventLoopGroup: group
+ )
+
+ client = FlightClient(channel: channel)
+ }
+
+ deinit {
+ try? group?.syncShutdownGracefully()
+ try? channel?.close().wait()
+ }
+
+ func listActionTest() async throws {
+ var actionTypes = [FlightActionType]()
+ try await client?.listActions( { action in
+ actionTypes.append(action)
+ })
+
+ XCTAssertEqual(actionTypes.count, 2)
+ XCTAssertEqual(actionTypes[0].type, "type1")
+ XCTAssertEqual(actionTypes[0].description, "desc1")
+ XCTAssertEqual(actionTypes[1].type, "type2")
+ XCTAssertEqual(actionTypes[1].description, "desc2")
+ }
+
+ func listFlightsTest() async throws {
+ let flightCriteria = FlightCriteria("flight criteria expression".data(using: .utf8)!)
+ var num_calls = 0
+ try await client?.listFlights(flightCriteria, closure: { data in
+ num_calls += 1
+ let schema = try streamToArrowSchema(data.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ })
+
+ XCTAssertEqual(num_calls, 1)
+ }
+
+ func doActionTest() async throws {
+ let action = FlightAction("test_action", body: "test_action body".data(using: .utf8)!)
+ var actionResults = [FlightResult]()
+ try await client?.doAction(action, closure: { result in
+ actionResults.append(result)
+ })
+
+ XCTAssertEqual(actionResults.count, 1)
+ XCTAssertEqual(String(bytes:actionResults[0].body, encoding: .utf8), "test_action result")
+ }
+
+ func getSchemaTest() async throws {
+ let descriptor = FlightDescriptor(cmd: "schema info".data(using: .utf8)!)
+ let schemaResult = try await client?.getSchema(descriptor)
+ let schema = try streamToArrowSchema(schemaResult!.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ }
+
+ func doGetTest() async throws {
+ let ticket = FlightTicket("flight_ticket test".data(using: .utf8)!)
+ var num_call = 0
+ try await client?.doGet(ticket, readerResultClosure: { rb in
+ num_call += 1
+ XCTAssertEqual(rb.schema!.fields.count, 3)
+ XCTAssertEqual(rb.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doPutTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doPut([rb], closure: { result in
+ num_call += 1
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doExchangeTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doExchange([rb], closure: { result in
+ num_call += 1
+ XCTAssertEqual(result.schema?.fields.count, 3)
+ XCTAssertEqual(result.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+}
+
+actor FlightServerData {
+ public var serverup = false
Review Comment:
We may want to use `serverUp` for this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1263213782
##########
swift/ArrowFlight/Sources/ArrowFlight/FlightClient.swift:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+public class FlightClient {
+ let client: Arrow_Flight_Protocol_FlightServiceAsyncClient
+ public init(channel: GRPCChannel) {
+ client = Arrow_Flight_Protocol_FlightServiceAsyncClient(channel: channel)
+ }
+
+ public func listActions(_ closure: (FlightActionType) -> Void) async throws {
+ let listActions = client.makeListActionsCall(Arrow_Flight_Protocol_Empty())
+ for try await data in listActions.responseStream {
+ closure(FlightActionType(data))
+ }
+ }
+
+ public func listFlights(_ criteria :FlightCriteria, closure: (FlightInfo) throws -> Void ) async throws {
Review Comment:
```suggestion
public func listFlights(_ criteria: FlightCriteria, closure: (FlightInfo) throws -> Void) async throws {
```
(We may want to introduce code formatter.)
##########
swift/ArrowFlight/Sources/ArrowFlight/RecordBatchStreamReader.swift:
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import Foundation
+import Arrow
+import GRPC
+
+public class RecordBatchStreamReader: AsyncSequence, AsyncIteratorProtocol {
+ public typealias AsyncIterator = RecordBatchStreamReader
+ public typealias Element = RecordBatch
+ let reader = ArrowReader()
+ var batches = [RecordBatch]()
+ var batchIndex = 0
+ var streamIterator: any AsyncIteratorProtocol
+ let stream: GRPC.GRPCAsyncRequestStream<Arrow_Flight_Protocol_FlightData>
+ init(_ stream: GRPC.GRPCAsyncRequestStream<Arrow_Flight_Protocol_FlightData>) {
+ self.stream = stream
+ self.streamIterator = self.stream.makeAsyncIterator()
+ }
+
+ public func next() async throws -> Arrow.RecordBatch? {
+ guard !Task.isCancelled else {
+ return nil
+ }
+
+ if batchIndex < batches.count {
+ let batch = batches[batchIndex]
+ batchIndex += 1
+ return batch
+ }
+
+ while true {
+ let flight_data = try await self.streamIterator.next()
Review Comment:
`flightData`?
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
Review Comment:
```suggestion
} catch {
```
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ }catch {
+ print("Unknown server error: \(error)")
+ }
+ }
+}
+
+public class FlightClientImpl {
Review Comment:
`FlightClientTester` or something may be better.
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ }catch {
Review Comment:
```suggestion
} catch {
```
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import XCTest
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+@testable import ArrowFlight
+
+func makeSchema() -> ArrowSchema {
+ let schemaBuilder = ArrowSchema.Builder()
+ return schemaBuilder.addField("col1", type: ArrowType(ArrowType.ArrowUInt8), isNullable: true)
+ .addField("col2", type: ArrowType(ArrowType.ArrowString), isNullable: false)
+ .addField("col3", type: ArrowType(ArrowType.ArrowDate32), isNullable: false)
+ .finish()
+}
+
+func makeRecordBatch() throws -> RecordBatch {
+ let uint8Builder: NumberArrayBuilder<UInt8> = try ArrowArrayBuilders.loadNumberArrayBuilder()
+ uint8Builder.append(10)
+ uint8Builder.append(22)
+ uint8Builder.append(33)
+ uint8Builder.append(44)
+ let stringBuilder = try ArrowArrayBuilders.loadStringArrayBuilder()
+ stringBuilder.append("test10")
+ stringBuilder.append("test22")
+ stringBuilder.append("test33")
+ stringBuilder.append("test44")
+ let date32Builder = try ArrowArrayBuilders.loadDate32ArrayBuilder()
+ let date2 = Date(timeIntervalSinceReferenceDate: 86400 * 1)
+ let date1 = Date(timeIntervalSinceReferenceDate: 86400 * 5000 + 352)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ date32Builder.append(date1)
+ date32Builder.append(date2)
+ let intHolder = ArrowArrayHolder(try uint8Builder.finish())
+ let stringHolder = ArrowArrayHolder(try stringBuilder.finish())
+ let date32Holder = ArrowArrayHolder(try date32Builder.finish())
+ let result = RecordBatch.Builder()
+ .addColumn("col1", arrowArray: intHolder)
+ .addColumn("col2", arrowArray: stringHolder)
+ .addColumn("col3", arrowArray: date32Holder)
+ .finish()
+ switch result {
+ case .success(let recordBatch):
+ return recordBatch
+ case .failure(let error):
+ throw error
+ }
+}
+
+final class MyFlightServer : ArrowFlightServer {
+ func doExchange(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ do {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ }
+
+ let rb = try makeRecordBatch()
+ try await writer.write(rb)
+ }catch {
+ print("Unknown error: \(error)")
+ }
+ }
+
+ func doPut(_ reader: ArrowFlight.RecordBatchStreamReader, writer: ArrowFlight.PutResultDataStreamWriter) async throws {
+ for try await rb in reader {
+ XCTAssertEqual(rb.schema.fields.count, 3)
+ XCTAssertEqual(rb.length, 4)
+ try await writer.write(FlightPutResult())
+ }
+ }
+
+ func doGet(_ ticket: ArrowFlight.FlightTicket, writer: ArrowFlight.RecordBatchStreamWriter) async throws {
+ try await writer.write(try makeRecordBatch())
+ }
+
+ func getSchema(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightSchemaResult {
+ XCTAssertEqual(String(bytes: request.cmd, encoding: .utf8)!, "schema info")
+ XCTAssertEqual(request.type, .cmd)
+ return try ArrowFlight.FlightSchemaResult(schemaToArrowStream(makeSchema()))
+ }
+
+ func getFlightInfo(_ request: ArrowFlight.FlightDescriptor) async throws -> ArrowFlight.FlightInfo {
+ return ArrowFlight.FlightInfo(Data())
+ }
+
+ func listFlights(_ criteria: ArrowFlight.FlightCriteria, writer: ArrowFlight.FlightInfoStreamWriter) async throws {
+ XCTAssertEqual(String(bytes: criteria.expression, encoding: .utf8), "flight criteria expression")
+ let flight_info = try ArrowFlight.FlightInfo(schemaToArrowStream(makeSchema()))
+ try await writer.write(flight_info)
+ }
+
+ func listActions(_ writer: ArrowFlight.ActionTypeStreamWriter) async throws {
+ try await writer.write(FlightActionType("type1", description: "desc1"))
+ try await writer.write(FlightActionType("type2", description: "desc2"))
+ }
+
+ func doAction(_ action: FlightAction, writer: ResultStreamWriter) async throws {
+ XCTAssertEqual(action.type, "test_action")
+ XCTAssertEqual(String(bytes: action.body, encoding: .utf8)!, "test_action body")
+ try await writer.write(FlightResult("test_action result".data(using: .utf8)!))
+ }
+}
+
+struct FlightServerImpl {
+ var port = 1234
+ static var server: Server?
+ static var group: MultiThreadedEventLoopGroup?
+ static func run() async throws {
+ do {
+ // Create an event loop group for the server to run on.
+ let group = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount)
+ // Create a provider using the features we read.
+ let provider = ArrowFlight.MakeFlightServer(MyFlightServer())
+
+ // Start the server and print its address once it has started.
+ FlightServerImpl.server = try await Server.insecure(group: group)
+ .withServiceProviders([provider])
+ .bind(host: "localhost", port: 8088)
+ .get()
+
+ print("server started on port \(server!.channel.localAddress!.port!)")
+
+ // Wait on the server's `onClose` future to stop the program from exiting.
+ }catch {
+ print("Unknown server error: \(error)")
+ }
+ }
+}
+
+public class FlightClientImpl {
+ var client: FlightClient?
+ var group: MultiThreadedEventLoopGroup?
+ var channel: GRPCChannel?
+
+ init() async throws {
+ // Load the features.
+ let group = PlatformSupport.makeEventLoopGroup(loopCount: 1)
+ let channel = try GRPCChannelPool.with(
+ target: .host("localhost", port: 8088),
+ transportSecurity: .plaintext,
+ eventLoopGroup: group
+ )
+
+ client = FlightClient(channel: channel)
+ }
+
+ deinit {
+ try? group?.syncShutdownGracefully()
+ try? channel?.close().wait()
+ }
+
+ func listActionTest() async throws {
+ var actionTypes = [FlightActionType]()
+ try await client?.listActions( { action in
+ actionTypes.append(action)
+ })
+
+ XCTAssertEqual(actionTypes.count, 2)
+ XCTAssertEqual(actionTypes[0].type, "type1")
+ XCTAssertEqual(actionTypes[0].description, "desc1")
+ XCTAssertEqual(actionTypes[1].type, "type2")
+ XCTAssertEqual(actionTypes[1].description, "desc2")
+ }
+
+ func listFlightsTest() async throws {
+ let flightCriteria = FlightCriteria("flight criteria expression".data(using: .utf8)!)
+ var num_calls = 0
+ try await client?.listFlights(flightCriteria, closure: { data in
+ num_calls += 1
+ let schema = try streamToArrowSchema(data.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ })
+
+ XCTAssertEqual(num_calls, 1)
+ }
+
+ func doActionTest() async throws {
+ let action = FlightAction("test_action", body: "test_action body".data(using: .utf8)!)
+ var actionResults = [FlightResult]()
+ try await client?.doAction(action, closure: { result in
+ actionResults.append(result)
+ })
+
+ XCTAssertEqual(actionResults.count, 1)
+ XCTAssertEqual(String(bytes:actionResults[0].body, encoding: .utf8), "test_action result")
+ }
+
+ func getSchemaTest() async throws {
+ let descriptor = FlightDescriptor(cmd: "schema info".data(using: .utf8)!)
+ let schemaResult = try await client?.getSchema(descriptor)
+ let schema = try streamToArrowSchema(schemaResult!.schema)
+ XCTAssertEqual(schema.fields.count, 3)
+ }
+
+ func doGetTest() async throws {
+ let ticket = FlightTicket("flight_ticket test".data(using: .utf8)!)
+ var num_call = 0
+ try await client?.doGet(ticket, readerResultClosure: { rb in
+ num_call += 1
+ XCTAssertEqual(rb.schema!.fields.count, 3)
+ XCTAssertEqual(rb.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doPutTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doPut([rb], closure: { result in
+ num_call += 1
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+
+ func doExchangeTest() async throws {
+ let rb = try makeRecordBatch()
+ var num_call = 0
+ try await client?.doExchange([rb], closure: { result in
+ num_call += 1
+ XCTAssertEqual(result.schema?.fields.count, 3)
+ XCTAssertEqual(result.batches[0].length, 4)
+ })
+
+ XCTAssertEqual(num_call, 1)
+ }
+}
+
+var serverup = false
Review Comment:
Can we move this to `testFlightServer()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1268290947
##########
swift/ArrowFlight/Sources/ArrowFlight/FlightClient.swift:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import struct Foundation.Data
+import struct Foundation.URL
+import GRPC
+import NIOCore
+import NIOPosix
+import Arrow
+
+public class FlightClient {
+ let client: Arrow_Flight_Protocol_FlightServiceAsyncClient
+ public init(channel: GRPCChannel) {
+ client = Arrow_Flight_Protocol_FlightServiceAsyncClient(channel: channel)
+ }
+
+ public func listActions(_ closure: (FlightActionType) -> Void) async throws {
+ let listActions = client.makeListActionsCall(Arrow_Flight_Protocol_Empty())
+ for try await data in listActions.responseStream {
+ closure(FlightActionType(data))
+ }
+ }
+
+ public func listFlights(_ criteria :FlightCriteria, closure: (FlightInfo) throws -> Void ) async throws {
Review Comment:
Will change, agreed, I will start looking around.
##########
swift/ArrowFlight/Sources/ArrowFlight/RecordBatchStreamReader.swift:
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import Foundation
+import Arrow
+import GRPC
+
+public class RecordBatchStreamReader: AsyncSequence, AsyncIteratorProtocol {
+ public typealias AsyncIterator = RecordBatchStreamReader
+ public typealias Element = RecordBatch
+ let reader = ArrowReader()
+ var batches = [RecordBatch]()
+ var batchIndex = 0
+ var streamIterator: any AsyncIteratorProtocol
+ let stream: GRPC.GRPCAsyncRequestStream<Arrow_Flight_Protocol_FlightData>
+ init(_ stream: GRPC.GRPCAsyncRequestStream<Arrow_Flight_Protocol_FlightData>) {
+ self.stream = stream
+ self.streamIterator = self.stream.makeAsyncIterator()
+ }
+
+ public func next() async throws -> Arrow.RecordBatch? {
+ guard !Task.isCancelled else {
+ return nil
+ }
+
+ if batchIndex < batches.count {
+ let batch = batches[batchIndex]
+ batchIndex += 1
+ return batch
+ }
+
+ while true {
+ let flight_data = try await self.streamIterator.next()
Review Comment:
Will do.,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abandy commented on a diff in pull request #36547: GH-36546: [Swift] The initial implementation for swift arrow flight
Posted by "abandy (via GitHub)" <gi...@apache.org>.
abandy commented on code in PR #36547:
URL: https://github.com/apache/arrow/pull/36547#discussion_r1261635336
##########
swift/ArrowFlight/Tests/ArrowFlightTests/FlightTest.swift:
##########
Review Comment:
Good catch! Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org