You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by Zhang-Ke <gi...@git.apache.org> on 2016/12/26 10:27:37 UTC

[GitHub] incubator-rocketmq pull request #15: [ROCKETMQ-16] Improve the codes of sett...

GitHub user Zhang-Ke opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/15

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path
    
    JIRRA ISSUE: [https://issues.apache.org/jira/browse/ROCKETMQ-16](url)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-16

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 7287170a92e52241832a2b5b8930f8f60b9e1fae
Author: zhangke <zh...@qq.com>
Date:   2016-12-26T10:21:06Z

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #15: [ROCKETMQ-16] Improve the codes of sett...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #15: [ROCKETMQ-16] Improve the codes of setting top...

Posted by vongosling <gi...@git.apache.org>.

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/15
  
    IMO, we can postpone merge this PR here, thanks @Zhang-Ke 
    About config module, we would refactor here in the latest release version :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #15: [ROCKETMQ-16] Improve the codes of setting top...

Posted by zhouxinyu <gi...@git.apache.org>.

Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/15
  
    It looks good, please @vongosling @lollipopjin  review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---