You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/03/13 18:44:15 UTC
[PR] Fix scan metrics test to run with both native_datafusion and native_iceberg_compat [datafusion-comet]
andygrove opened a new pull request, #3690:
URL: https://github.com/apache/datafusion-comet/pull/3690
## Which issue does this PR close?
N/A - test coverage improvement
## Rationale for this change
The "Comet native metrics: scan" test in `CometExecSuite` only ran with `SCAN_AUTO` (which resolves to `native_iceberg_compat`), providing no coverage for the `native_datafusion` scan mode. Additionally, the test used `find().foreach()` which silently passed if no scan node was found.
## What changes are included in this PR?
- Run the scan metrics test with both `SCAN_NATIVE_DATAFUSION` and `SCAN_NATIVE_ICEBERG_COMPAT` explicitly
- Use `find()` with `assert(scan.isDefined, ...)` instead of `find().foreach()` to fail explicitly if no scan node is found
- Remove the `WHERE _2 > _3` filter clause. With `native_datafusion`, predicate pushdown pruned all 10,000 rows (since `_2` and `_3` have identical values with dictionary encoding), resulting in `output_rows = 0` and the metric assertions failing. The test's purpose is to verify metrics plumbing, not filter behavior.
- Add scan mode context to assertion messages for easier debugging
## How are these changes tested?
The PR itself is a test improvement. Verified by running `CometExecSuite` — all 88 tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix scan metrics test to run with both native_datafusion and native_iceberg_compat [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #3690:
URL: https://github.com/apache/datafusion-comet/pull/3690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org