You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Martin Ritchie <ri...@apache.org> on 2009/10/22 12:06:50 UTC

Re: svn commit: r828019 - in /qpid/trunk/qpid/java/client/src/main/java: log4j.xml org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java

Apologies, I didn't intend to remove the log4j.xml file in this commit.

I do however strongly object to its inclusion. The files existence
will cause Qpid end users a lot of problems.

Specifically the logging that the end user gets will depend on their
classpath... a very poor solution IMO.

I shall restore the file for now, but I would like to reach a
understanding as to why it was included before we do a release of the
Java client libraries.

Regards

Martin

2009/10/21  <ri...@apache.org>:
> Author: ritchiem
> Date: Wed Oct 21 14:04:00 2009
> New Revision: 828019
>
> URL: http://svn.apache.org/viewvc?rev=828019&view=rev
> Log:
> Update PropertiesFileInitialContextFactory to give more details on error.
>
> Removed:
>    qpid/trunk/qpid/java/client/src/main/java/log4j.xml
> Modified:
>    qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java
>
> Modified: qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java
> URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java?rev=828019&r1=828018&r2=828019&view=diff
> ==============================================================================
> --- qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java (original)
> +++ qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java Wed Oct 21 14:04:00 2009
> @@ -108,7 +108,8 @@
>         }
>         catch (IOException ioe)
>         {
> -            _logger.warn("Unable to load property file specified in Provider_URL:" + environment.get(Context.PROVIDER_URL));
> +            _logger.warn("Unable to load property file specified in Provider_URL:" + environment.get(Context.PROVIDER_URL) +"\n" +
> +                         "Due to:"+ioe.getMessage());
>         }
>
>         createConnectionFactories(data, environment);
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:commits-subscribe@qpid.apache.org
>
>



-- 
Martin Ritchie

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org