You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/01 13:22:38 UTC

[GitHub] [iceberg] gaborkaszab opened a new issue #1543: numBuckets can cause division by zero

gaborkaszab opened a new issue #1543:
URL: https://github.com/apache/iceberg/issues/1543


   The numBuckets member in Bucket class is not verified and I managed to create a table with a Bucket partition with zero buckets. This later could cause an exception due to modulo by zero here:
   https://github.com/apache/iceberg/blob/c28d1c8ba6322af07f0206c4cf3fdad875f37ac1/api/src/main/java/org/apache/iceberg/transforms/Bucket.java#L87
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangdove commented on issue #1543: numBuckets can cause division by zero

Posted by GitBox <gi...@apache.org>.
zhangdove commented on issue #1543:
URL: https://github.com/apache/iceberg/issues/1543#issuecomment-705993764


   We can do some validation on the input parameters when creating the bucket partition.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangdove commented on issue #1543: numBuckets can cause division by zero

Posted by GitBox <gi...@apache.org>.
zhangdove commented on issue #1543:
URL: https://github.com/apache/iceberg/issues/1543#issuecomment-705997827


   It seems that some time has passed and there is no reply. I would provide a relevant PR to fix this small problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangdove commented on issue #1543: numBuckets can cause division by zero

Posted by GitBox <gi...@apache.org>.
zhangdove commented on issue #1543:
URL: https://github.com/apache/iceberg/issues/1543#issuecomment-705993764






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org