[GitHub] [shardingsphere] sandynz commented on a change in pull request #12130: Whether cluster need to auto switch could be customized by conf and SPI when scaling task almost finished

[GitBox <gi...@apache.org>]

sandynz commented on a change in pull request #12130:
URL: https://github.com/apache/shardingsphere/pull/12130#discussion_r699817729



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/executor/job/FinishedCheckJobExecutor.java
##########
@@ -37,6 +39,11 @@
     @Override
     public void start() {
         super.start();
+        ScalingClusterAutoSwitchAlgorithm clusterAutoSwitchAlgorithm = ScalingContext.getInstance().getClusterAutoSwitchAlgorithm();
+        if (null == clusterAutoSwitchAlgorithm) {
+            log.info("clusterAutoSwitchAlgorithm not configured, finished check job will not start");

Review comment:
       Ok, operation suggestion added.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org