[GitHub] [commons-text] garydgregory commented on a diff in pull request #430: removed unnecessary IF statement

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #430:
URL: https://github.com/apache/commons-text/pull/430#discussion_r1242769008


##########
src/main/java/org/apache/commons/text/AlphabetConverter.java:
##########
@@ -87,9 +87,6 @@ public final class AlphabetConverter {
      * @see "http://www.oracle.com/us/technologies/java/supplementary-142654.html"
      */
     private static String codePointToString(final int i) {
-        if (Character.charCount(i) == 1) {

Review Comment:
   While undocumented with an inline comment here, this appears to be an optimization (or an attempt at least). 
   
   @kinow Do you know why the code is this way and if it should remain so? It looks like we both touched this method based on git blame and that the change might have come from a PR/Patch from someone at Paypal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org