You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/06/04 17:45:30 UTC

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

Hello Michael Ho, Michael Brown, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10466

to look at the new patch set (#3).

Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................

IMPALA-6947: Kudu tests flaky due to rpc timeout

Some Kudu tests occasionally fail due to hitting an rpc timeout when
running on a heavily loaded machine. For normal operation, having a
low timeout is good for noticing issues quickly, but for tests there's
no real reason we can't set this higher to avoid flakiness.

This patch adds a flag, -kudu_client_rpc_timeout_ms, disabled by
default. It also sets -kudu_client_rpc_timeout_ms to 60s for ASAN in
start-impala-cluster.py, higher than Kudu's default value of 10s.

Testing:
- Passed a full run of core tests on ASAN.

Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
M bin/start-impala-cluster.py
3 files changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10466/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10466
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>