[jira] Commented: (WICKET-2659) Improve exception handling with dynamically instantiated ErrorExceptionPage

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801472#action_12801472 ] 

Juergen Donnerstag commented on WICKET-2659:
--------------------------------------------

thanks for the patch. We'll review it once again when 1.5 is more stable. Due to the API changes, it can not be applied to 1.4

> Improve exception handling with dynamically instantiated ErrorExceptionPage
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2659
>                 URL: https://issues.apache.org/jira/browse/WICKET-2659
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.5, 1.4.6, 1.5-M1
>            Reporter: Ilja Pavkovic
>         Attachments: WICKET-2659.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> based on the discussion at 
> http://old.nabble.com/error-page-td26968559.html
> I introduced the concept of a dynamically instantiated errorpage. If one uses a customized error page with
>                 getApplicationSettings().setInternalErrorPage(MyErrorPage.class);
>                 getExceptionSettings().setUnexpectedExceptionDisplay(IExceptionSettings.SHOW_INTERNAL_ERROR_PAGE);
> neither the exception nor the responsePage can be accessed. Analogous the handling of Pages with PageParameters 
> the request cycle tries to find and use a constructor like
> public MyErrorPage(final Throwable throwable, final Page page) {
> ..
> }
> If this constructor is not found, wicket uses
> public MyErrorPage() {
> ...} 
> as fallback.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.