You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/12/18 20:49:32 UTC
[GitHub] incubator-zeppelin pull request: Enhanced/floating table header
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/554
Enhanced/floating table header
### What is this PR for?
if you express a lot of table Row of Zeppelin, when the Column Title have to scroll down, it is invisible and inconvenient.
So, I have to change the Zeppelin Table Column Title was modified to always display.
### What type of PR is it?
Improvement
### Todos
- [x] implement Fixed Column Title for table
- [x] Browser Test
- [x] Safari
- [x] Firefox
- [x] Chrome
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-518
### How should this be tested?
step 1. many rows table print.
example query)
``` python
%pyspark
TABLE = "%table Header1\tHeader2\tHeader3\tHeader4\n"
for x in range(1,101):
TABLE += str(x) + ""
if (x%4) == 0:
TABLE += "\n"
else:
TABLE += "\t"
z.put("table_context", TABLE)
```
``` python
println(z.get("table_context"))
```
step 2. Scroll the mouse over the Table.
### Screenshots (if appropriate)
Animated Gif.
### Questions:
How tables are expressed in browsers that do not support this feature?
- As before Header mouse scrolling moves along.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin enhanced/floating_table_header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #554
----
commit ba7ca8ebfe4425bb4fe2a64a447f995451e61d68
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-18T11:25:58Z
Fixed Table Header
commit 38d70b46179846cb0bac1b5658b0ae2e46e1b50d
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-18T19:15:29Z
Support Firefox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/554#issuecomment-166165000
It is changed.
Delete Unused thead.
Add margin-top table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/554#issuecomment-166098208
Its better to remove the unused thead content (to free some binding)
You could remove the ``<thead>`` part in the previous table, and add ``margin-top: 31px;`` to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/554#issuecomment-165889196
@astroshim Thank you for feed back!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/554#issuecomment-165888962
This function is very useful for users!
And the code what you added is the brilliant trick i think. :)
I tested this function at chrome/firefox/explorer and it's working well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-518 ] always top fixed c...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/554#issuecomment-166099804
@corneadoug Thank you for good advice.
I will modify it as you advise.
unused thead -> margin top 31px;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---