You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/01/31 02:54:12 UTC
[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5831
Change subject: consensus_peers-test: Call FsManager::Open() in SetUp()
......................................................................
consensus_peers-test: Call FsManager::Open() in SetUp()
This test previously neglected to call FsManager::Open() after
FsManager::CreateInitialFileSystemLayout(), resulting in an invalid
state for the FsManager in this test.
Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
---
M src/kudu/consensus/consensus_peers-test.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/5831/1
--
To view, visit http://gerrit.cloudera.org:8080/5831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: consensus_peers-test: Call FsManager::Open() in SetUp()
......................................................................
Patch Set 1:
I just don't think this test previously called uuid() or other checked methods.
--
To view, visit http://gerrit.cloudera.org:8080/5831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: consensus_peers-test: Call FsManager::Open() in SetUp()
......................................................................
Patch Set 1: Verified+1
Overriding unrelated test failure (raft_consensus-itest)
--
To view, visit http://gerrit.cloudera.org:8080/5831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: consensus_peers-test: Call FsManager::Open() in SetUp()
......................................................................
consensus_peers-test: Call FsManager::Open() in SetUp()
This test previously neglected to call FsManager::Open() after
FsManager::CreateInitialFileSystemLayout(), resulting in an invalid
state for the FsManager in this test.
Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Reviewed-on: http://gerrit.cloudera.org:8080/5831
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/consensus/consensus_peers-test.cc
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Mike Percy: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: consensus_peers-test: Call FsManager::Open() in SetUp()
......................................................................
Patch Set 1: Code-Review+2
So how did the test pass at all?
--
To view, visit http://gerrit.cloudera.org:8080/5831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I077fc2c95257c48a24e1e8fe87516293881ce5c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No