You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stefan Seifert (Jira)" <ji...@apache.org> on 2020/06/04 07:18:00 UTC

[jira] [Commented] (SLING-9500) Support javax.servlet.ServletRequest#getLocales in servlet-helpers

    [ https://issues.apache.org/jira/browse/SLING-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125618#comment-17125618 ] 

Stefan Seifert commented on SLING-9500:
---------------------------------------

lgtm

> Support javax.servlet.ServletRequest#getLocales in servlet-helpers
> ------------------------------------------------------------------
>
>                 Key: SLING-9500
>                 URL: https://issues.apache.org/jira/browse/SLING-9500
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlet Helpers 1.3.0
>            Reporter: Dirk Rudolph
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Apache Sling I18n DefaultLocaleResolver used in the i18n filter uses getLocales() to obtain the locales associated with the request [1]. When using MockSlingHttpServletRequest with the SlingRequestProcessor and having the i18n Filter in the filter chain this will cause the mock request to fail.
>  
> [1] [https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/DefaultLocaleResolver.java#L51]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)