You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/12 23:28:06 UTC

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #6906: Various bugs in passes

mbrookhart commented on a change in pull request #6906:
URL: https://github.com/apache/incubator-tvm/pull/6906#discussion_r522500934



##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -1076,7 +1076,7 @@ Examples::
     .set_support_level(3)
     .add_type_rel("Take", TakeRel)
     .set_attr<FTVMCompute>("FTVMCompute", TakeCompute)
-    .set_attr<TOpPattern>("TOpPattern", kInjective);
+    .set_attr<TOpPattern>("TOpPattern", kOpaque);

Review comment:
       Good thing I have a typo in CI.
   
   I'm not sure I see a clean way to do this in the frontends, it demands we already have infer_type run to check for dynamic inputs.
   
   Maybe we write a pass that selectively stops fusion on certain ops under certain conditions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org