You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/23 02:28:23 UTC
[GitHub] [airflow] sunkickr opened a new pull request #15499: Add Connection Documentation for Providers
sunkickr opened a new pull request #15499:
URL: https://github.com/apache/airflow/pull/15499
This PR documents connections for the following providers
- MySQL
- Slack
- Tableau
- Neo4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-825982792
Please rebase on latest master please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr commented on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-826134851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on a change in pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr commented on a change in pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#discussion_r619201219
##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -41,7 +41,7 @@ class MySQLToS3Operator(BaseOperator):
:type s3_bucket: str
:param s3_key: desired key for the file. It includes the name of the file. (templated)
:type s3_key: str
- :param mysql_conn_id: reference to a specific mysql database
+ :param mysql_conn_id: :ref:Reference to `mysql connection id<howto/connection:mysql>`.
Review comment:
yes you right, sorry messed that up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr removed a comment on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr removed a comment on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-826134851
@kaxil just rebased to the latest master thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#discussion_r618901658
##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -41,7 +41,7 @@ class MySQLToS3Operator(BaseOperator):
:type s3_bucket: str
:param s3_key: desired key for the file. It includes the name of the file. (templated)
:type s3_key: str
- :param mysql_conn_id: reference to a specific mysql database
+ :param mysql_conn_id: :ref:Reference to `mysql connection id<howto/connection:mysql>`.
Review comment:
Is this the correct quoting? I’d expect something like this instead:
```rst
:ref:`Reference to mysql connection id <howto/connection:mysql>`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#discussion_r618901658
##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -41,7 +41,7 @@ class MySQLToS3Operator(BaseOperator):
:type s3_bucket: str
:param s3_key: desired key for the file. It includes the name of the file. (templated)
:type s3_key: str
- :param mysql_conn_id: reference to a specific mysql database
+ :param mysql_conn_id: :ref:Reference to `mysql connection id<howto/connection:mysql>`.
Review comment:
Is this the correct quoting? I’d expect something like
```rst
:ref:`Reference to mysql connection id <howto/connection:mysql>`
```
or
```rst
Reference to :ref:`mysql connection id <howto/connection:mysql>`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15499:
URL: https://github.com/apache/airflow/pull/15499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr removed a comment on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr removed a comment on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-826134851
@kaxil just rebased to the latest master thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr commented on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-826134851
@kaxil just rebased to the latest master thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-825654224
[The Workflow run](https://github.com/apache/airflow/actions/runs/777817646) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr commented on pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#issuecomment-826143257
There are few static errors I'll fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on a change in pull request #15499: Add Connection Documentation for Providers
Posted by GitBox <gi...@apache.org>.
sunkickr commented on a change in pull request #15499:
URL: https://github.com/apache/airflow/pull/15499#discussion_r619207915
##########
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##########
@@ -41,7 +41,7 @@ class MySQLToS3Operator(BaseOperator):
:type s3_bucket: str
:param s3_key: desired key for the file. It includes the name of the file. (templated)
:type s3_key: str
- :param mysql_conn_id: reference to a specific mysql database
+ :param mysql_conn_id: :ref:Reference to `mysql connection id<howto/connection:mysql>`.
Review comment:
just fixed all the mistakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org