You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/18 13:17:26 UTC

[GitHub] [beam] rehmanmuradali commented on a change in pull request #11350: [BEAM-1589] Added @OnWindowExpiration annotation.

rehmanmuradali commented on a change in pull request #11350:
URL: https://github.com/apache/beam/pull/11350#discussion_r426618001



##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
##########
@@ -552,7 +552,11 @@ public void flushState() {
       if (!cachedFiredTimers.hasNext()) {
         return null;
       }
-      return cachedFiredTimers.next();
+      TimerData nextTimer = cachedFiredTimers.next();
+      // system timers ( GC timer) must be explicitly deleted when delivered, to release the implied
+      // hold.
+      systemTimerInternals.deleteTimer(nextTimer);

Review comment:
       @reuvenlax done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org