[GitHub] [superset] anilvpatel21 commented on issue #13430: New alerts: Grace period does not work as expected

[GitBox <gi...@apache.org>]

anilvpatel21 commented on issue #13430:
URL: https://github.com/apache/superset/issues/13430#issuecomment-919703822


   @randalee Thanks for the code. 
   
   It make sense, as if it's not in grace period, we need to check AlertCommand and then send the alert if it's triggered (exceed the threshold). 
   
   you must raise a PR for this and get an overview/thinking of the authors why they have written a code like this in ALERT Type. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org