[GitHub] [tvm] srkreddy1238 commented on a diff in pull request #13450: [COLLAGE] Add more customization to support more targets

[GitBox <gi...@apache.org>]

srkreddy1238 commented on code in PR #13450:
URL: https://github.com/apache/tvm/pull/13450#discussion_r1046626218


##########
tests/python/contrib/test_clml/menangerie.py:
##########
@@ -0,0 +1,4179 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   I see only resnet50, resnet50_16, mobilenet, mobilenet_16 are used for test cases.
   You may remove other network definitions here.



##########
tests/python/contrib/test_clml/test_adreno_collage_targets.py:
##########
@@ -0,0 +1,400 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Compares Collage with various other baselines."""
+
+# CAUTION: Requires some changes in python/tvm/autotvm/task/dispatcher.py

Review Comment:
   Is this caution relevant here ? i.e Do we need changes to AutoTVM ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org