[GitHub] [superset] villebro commented on pull request #22065: revert: feat: support None operand in EQUAL operator (#21713)"

[GitBox <gi...@apache.org>]

villebro commented on PR #22065:
URL: https://github.com/apache/superset/pull/22065#issuecomment-1311488601

   @john-bodley I echo @zhaoyongjie 's comments here that the original PR was not intended to directly make it's way into the UI; rather, the intent was to facilitate drilling/cross filtering, where a user may click on a *NULL* slice, and is expecting that to trigger a where clause that specifically picks out NULLs.
   
   I agree that
   ```sql
   dim_country IN ('<NULL>', 'foo')
   ```
   should not equate to
   ```sql
   "dim_country IS NULL OR dim_county IN ('foo')
   ```
   , so this should definitely be addressed. If I were to quickly open a PR that fixes this (=makes sure the frontend sends NULL filter events as real `null`s, not `'<NULL>'` string literals, and the backend stops interpreting `'<NULL>'` string literals as `None` in the backend), are you ok closing this revert PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org