You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by murkrishn <gi...@git.apache.org> on 2015/12/24 08:20:08 UTC
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
GitHub user murkrishn opened a pull request:
https://github.com/apache/incubator-eagle/pull/39
EAGLE-47 Ability to audit who made changes to Eagle policies
Code change includes implementation of audit functionality. Documentation of the generic API design for the same is available [here](https://github.com/apache/incubator-eagle/files/71519/eagle_47_generic_audit_api_design.pdf).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/murkrishn/incubator-eagle EAGLE-47
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 323e8d98a53df35ae3b28f741743f8637db52248
Author: murkrishn <mu...@ebay.com>
Date: 2015-12-24T04:46:14Z
Initial commit for code changes related to jira EAGLE-47. Code changes include implementation of audit functionality.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by anyway1021 <gi...@git.apache.org>.
Github user anyway1021 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/39#issuecomment-168128525
@yonzhang , if we're going to run the script and merge, PRs need an approval comment on the page. The approval comment should contain a single line with a string, either ":+1:", or "LGTM", we can regard these 2 string as approval marks.
Please take notice, the marks should take 1 single line with no other messages, just like below:
:+1:
or
LGTM
Then, when you execute the merge script, it will verify and know that this PR is reviewed and approved to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by murkrishn <gi...@git.apache.org>.
Github user murkrishn commented on the pull request:
https://github.com/apache/incubator-eagle/pull/39#issuecomment-167935839
For the particular implementation in HBaseStorageAudit, we would be auditing the HBase operations only for the services - AlertDefinitionService and AlertDataSourceService provided the auditing option is also enabled . Having named registering of implementation will help us to include/remove another implementation if required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/39#issuecomment-167933822
One comment: why do we need named audit listener? I see HBaseStorageAudit.isAuditingRequired checks if the passed service name matches "AlertDefinitionService" or "AlertDataSourceService".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/39#issuecomment-168128889
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/39#issuecomment-167936602
understood, please go ahead to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-47 Ability to audit who made c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---