You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by "James Leigh (JIRA)" <ji...@apache.org> on 2013/05/29 16:35:20 UTC

[jira] [Commented] (HTTPCLIENT-1358) MainClientExec Does Too Much

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669299#comment-13669299 ] 

James Leigh commented on HTTPCLIENT-1358:
-----------------------------------------

I was just trying to reduce code duplication between my project and httpclient. In my project, I want to support authentication over non-socket connections. This was my motivation for moving the authentication related code out of MainClientExec to HttpAuthenticator. This patch allows me to reuse the authentication code in my project for non-socket connections.
                
> MainClientExec Does Too Much
> ----------------------------
>
>                 Key: HTTPCLIENT-1358
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1358
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3 Beta1
>            Reporter: James Leigh
>            Priority: Trivial
>              Labels: patch
>             Fix For: 4.3 Beta2
>
>         Attachments: HTTPCLIENT-1358.patch
>
>
> MainClientExec directs the route, establishes connections, handles target authentication and handles proxy authentication. It is involved with both the connection/route management and the authentication semantics.
> It is currently too hard to intercept/handle httpclient requests without serializing them in a socket first. If the authentication was handled in a different class, then the connection route/timeout management, it would be easier to provide custom handling on the client side using the complete request (including auth headers).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org