You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/09 13:23:15 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #4391: Cleanup downcast macros

alamb commented on code in PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391#discussion_r1224301361


##########
arrow-array/src/cast.rs:
##########
@@ -577,7 +577,7 @@ macro_rules! downcast_run_array {
 }
 
 /// Force downcast of an [`Array`], such as an [`ArrayRef`] to
-/// [`GenericListArray<T>`], panic'ing on failure.
+/// [`GenericListArray<T>`], panicking on failure.

Review Comment:
   Past participle strikes again
   
   This is consistent with the Rust terminology so 👍 
   
   https://doc.rust-lang.org/std/thread/fn.panicking.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org