You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/07 21:09:32 UTC

[GitHub] nskool opened a new pull request #10842: Update expected result in osx python install script

nskool opened a new pull request #10842: Update expected result in osx python install script
URL: https://github.com/apache/incubator-mxnet/pull/10842
 
 
   * Change the expected value writtent to file mxnet_test.expected
   
   ## Description ##
   The bash script install-mxnet-osx-python.sh checks for an array created using MXNet. However, the formatting for the expected result is slightly incorrect (extra spaces in a couple of places).
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Installation verified on an OSX machine
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] 1
   * The install script (in its final step) checks if the following array was correctly created: mx.nd.ones((2, 3))*2.
   * The array checked is formatted as: 
   [[ 2.  2.  2.]
    [ 2.  2.  2.]]
   * However, it should be formatted as:
   [[2. 2. 2.]
     2. 2. 2.]]
   - Checked by re-installing MXNet on osx machines a couple of times.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services