[GitHub] [ant] bodewig commented on pull request #198: Using static modifier to normalize methods contract and performance

["bodewig (via GitHub)" <gi...@apache.org>]

bodewig commented on PR #198:
URL: https://github.com/apache/ant/pull/198#issuecomment-1422055507

   I must say I find it extremely difficult to properly review a PR that touches 100+ files, even if the change is supposed to be mechanical.
   
   In this case I saw a change to `Antlib.java` where a string literal was replaced by a constant defined somewhere else in the class - a place that is not visible inside the diff so I need to look up its definition elsewhere. This not only makes the review more difficult it also means I can not just scroll down the page and press merge as the set of changes obviously also contains changes not described by the headline.
   
   All in all I don't see myself being able to review this in any reasonable time frame. If you want to see this applied, please cut it into smaller chunks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org