[GitHub] jlahoda commented on a change in pull request #927: Enable travis for java.completion

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #927: Enable travis for java.completion
URL: https://github.com/apache/incubator-netbeans/pull/927#discussion_r221825370
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -24,14 +24,25 @@ script:
   - if [ "x$EOL" == "xtrue" ]; then ./travis-check-line-endings.sh; fi
   - if [ "x$SIGTEST" == "xtrue" ]; then ant check-sigtests; fi
   - if [ "x$CV" == "xtrue" ]; then ant -quiet -f ergonomics/ide.ergonomics/ test -Dtest.config=commit; fi
+  - if [ "x$RUN_TESTS_JDK8" == "xtrue" ]; then for MODULE in $TEST_MODULES; do cd $MODULE; ant test; done; fi
+  - if [ "x$RUN_TESTS_JDK9PLUS" == "xtrue" ]; then wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh && export TEST_JDK=`bash install-jdk.sh $TEST_JDK_VERSION --emit-java-home --silent | tail -1` && for MODULE in $TEST_MODULES; do cd $MODULE; ant "-Dtest.nbjdk.home=$TEST_JDK" $TEST_RUN_OPTIONS test; done; fi
 
 Review comment:
   Yes. The question is whether that's wrong: if the location of the JDKs to download change, the script may need to be adjusted, etc. So does not seem that much off. Also inspired by blogs like:
   https://sormuras.github.io/blog/2017-12-08-install-jdk-on-travis.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists