[jira] [Commented] (HDFS-5596) Implement RPC stubs

["Chris Nauroth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845915#comment-13845915 ] 

Chris Nauroth commented on HDFS-5596:
-------------------------------------

Nice work, Haohui.  A few comments:
# {{ClientProtocol}}: All RPCs can be annotated idempotent.  The implementation will be such that repeated application of the same request will yield the same result.  For example, a retried {{removeDefaultAcl}} call yields the same result whether the first call reaches the server, the second call reaches the server, or both.  The end result is always the prior ACL entries with all default entries removed.
# {{ReadonlyIterableAdaptor}}: (Optional) Do you think this is worth promoting to a top-level class in {{org.apache.hadoop.hdfs.util}}?  It's not directly coupled to the rest of the serialization code, and perhaps it will be useful elsewhere.
# {{DFSClient}}: There are a few more exception types that would be helpful to unwrap on the modification operations.  I think the full list of interesting exceptions for all modification operations would be: {{AccessControlException}}, {{FileNotFoundException}}, {{SafeModeException}}, {{UnresolvedPathException}}, {{SnapshotAccessControlException}}, and {{NSQuotaExceededException}}.  However, I'm also wondering if we ought to simplify the whole thing and call {{unwrapRemoteException}} with no args for all of these new methods.  What do you think?
# {{TestPBHelper}}: Let's add a test for conversion of {{AclStatus}} too.



> Implement RPC stubs
> -------------------
>
>                 Key: HDFS-5596
>                 URL: https://issues.apache.org/jira/browse/HDFS-5596
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Haohui Mai
>         Attachments: HDFS-5596.000.patch
>
>
> Implement RPC stubs for both {{DistributedFileSystem}} and {{NameNodeRpcServer}}.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)